Repository navigation
#274 - CI: test the lowest dependencies, fix the lower bounds of psr/log and monolog/monolog - #287
Merged
Merged
Conversation
…log and monolog/monolog - New CI job: PHP 8.2 with dependency-versions: lowest (composer update --prefer-lowest --prefer-stable). - psr/log ^2|^3: Logger\AbstractLogger (and the test loggers) implement the typed LoggerInterface signatures, a fatal error with psr/log 1, which was allowed through the Symfony components. - monolog/monolog ^3: the Logger\*Processor classes use Monolog\LogRecord (Monolog 3 only); with Monolog 2 (allowed by symfony/monolog-bundle 3.11), every log of the cleverage_process* channels would fail with a TypeError. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 14, 2026
This was referenced Oct 14, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #274: add a CI job testing the lowest versions allowed by
composer.json, and fix the lower bounds it revealed.Changes
.github/workflows/test.yml: new matrix entry, PHP 8.2 (lowest supported) withdependencies: lowest(ramsey/composer-installrunscomposer update --prefer-lowest --prefer-stable).psr/log^2|^3(not required until now, resolved to a 1.x version through the Symfony components, which allow^1|^2|^3):Logger\AbstractLogger(ProcessLogger,TaskLogger) and the test loggers declarelog($level, string|\Stringable $message, array $context = []): void, incompatible withpsr/log1:monolog/monolog^3(not required until now, resolved to 2.3.3 throughsymfony/monolog-bundle3.11): theLogger\*Processorclasses typeMonolog\LogRecord, a Monolog 3 class. With Monolog 2, MonologBundle would call them with an array record:TypeErroron every log of thecleverage_process*channels. Not visible in the tests (no test runs a processor through Monolog); checked thatMonolog\LogRecorddoes not exist with the lowest set.Related: #269 (optional MonologBundle) will have to keep the
monolog/monolog^3constraint, as a requirement or as aconflict: "monolog/monolog": "<3", if the processors stay registered.Checks
composer update --prefer-lowest --prefer-stable(Symfony 6.4.0,psr/log2.0.0,monolog/monolog3.0.0,psr/container1.1.0, PHPUnit 11.5): 906 tests OK. Before the fix: fatal error above.composer update: 906 tests OK, PHPStan OK,composer validate --strictOK.Requirements
Breaking changes
None in practice: the removed versions (
psr/log1,monolog/monolog2) could not work with the bundle (fatal error /TypeError).🤖 Generated with Claude Code